Fix unwrap error in individual feature importance #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawestra
requested review from
romanlutz,
gaugup,
xuke444,
tongyu-microsoft,
vinuthakaranth and
RubyZ10
as code owners
1 similar comment
gaugup
approved these changes
Jan 11, 2023
imatiach-msft
approved these changes
Jan 11, 2023
romanlutz
reviewed
Jan 11, 2023
libs/interpret/src/lib/MLIDashboard/Controls/GlobalExplanationTab/GlobalExplanationTab.tsx
Outdated
Show resolved
Hide resolved
…olbox into hawestra/robotPageUnwrapFix
…osoft/responsible-ai-toolbox into hawestra/robotPageUnwrapFix
romanlutz
approved these changes
Jan 12, 2023
xuke444
approved these changes
Jan 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use all data cohort as the default selected cohort if the currently selected cohort was deleted while the individual feature importance was using it. This bug was caused by React lifecycle events; the render function is using this.state.selectedCohortIndex on render but when the selected cohort gets deleted, this.props.cohorts is updated causing a re-render but this.state.selectedCohortIndex isn't updated until componentDidUpdate causing an out of index error.
Checklist