Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise UserConfigValidationException when treatment_feature is empty list #1904

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jan 13, 2023

Description

Raise UserConfigValidationException when treatment_feature is empty list to make we flag it is as user error.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

…ty list

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #1904 (50a6f08) into main (cac5590) will decrease coverage by 2.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
- Coverage   93.31%   90.64%   -2.68%     
==========================================
  Files          93       46      -47     
  Lines        4578     1881    -2697     
==========================================
- Hits         4272     1705    -2567     
+ Misses        306      176     -130     
Flag Coverage Δ
unittests 90.64% <ø> (-2.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onsibleai/responsibleai/managers/causal_manager.py
...ponsibleai/responsibleai/_tools/causal/__init__.py
responsibleai/responsibleai/managers/__init__.py
...tools/error_analysis/dashboard_schemas/__init__.py
...i/responsibleai/managers/counterfactual_manager.py
.../responsibleai/modelanalysis/constants/__init__.py
...ponsibleai/responsibleai/modelanalysis/__init__.py
responsibleai/responsibleai/_internal/__init__.py
...ai/responsibleai/_tools/causal/causal_constants.py
responsibleai/responsibleai/_data_validations.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup enabled auto-merge (squash) January 13, 2023 20:27
@gaugup gaugup merged commit 6c25ee2 into main Jan 13, 2023
@gaugup gaugup deleted the gaugup/CatchEmptyTreatmentList branch January 13, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants