-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise UserConfigValidationException
when treatment_feature
is empty list
#1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty list Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
January 13, 2023 01:09
Codecov Report
@@ Coverage Diff @@
## main #1904 +/- ##
==========================================
- Coverage 93.31% 90.64% -2.68%
==========================================
Files 93 46 -47
Lines 4578 1881 -2697
==========================================
- Hits 4272 1705 -2567
+ Misses 306 176 -130
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hawestra
approved these changes
Jan 13, 2023
tongyu-microsoft
approved these changes
Jan 13, 2023
vinuthakaranth
approved these changes
Jan 13, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raise
UserConfigValidationException
whentreatment_feature
is empty list to make we flag it is as user error.Checklist