Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable logarithmic scaling, reflect cohort change and add add Revert to bubble chart button #1905

Merged
merged 63 commits into from
Jan 17, 2023
Merged

Enable logarithmic scaling, reflect cohort change and add add Revert to bubble chart button #1905

merged 63 commits into from
Jan 17, 2023

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Jan 13, 2023 •
edited
Loading

Description

This PR contains changes in counterfactuals for below:

  1. Enable logarithmic toggle for scatter lot
  2. Add revert button to render bubble chart from scatter plot to select different cluster
  3. On cohort change update bubble chart

enaLogRevertBuCohort

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@vinuthakaranth
bub ch
5550302 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
5e2ad29 
…olbox into vikarant/bigdataBub

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
a00953a 
…olbox into vikarant/bigdataBub
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
1cf172c 
…olbox into vikarant/bigdataBub
@vinuthakaranth
update
0a707f2 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
root dep
cfaff8f 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update
d74e734 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
14dc2bd 
…olbox into vikarant/bigdataBub

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
b712f0f 
…olbox into vikarant/bigdataBub
@vinuthakaranth
localcounter code
4cb719c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update interface
a19a45d 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
local count
ed2c5ee 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update local imp chart marker
00c855e 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
allowtreatascat
25cdeef 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add few changes
cfe0abd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
enus change
2c22420 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
394765e 
…olbox into vikarant/bigdataBub

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
custom points updates
1af0837 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
custom point abs index changes
869e274 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
make local imp call async
4c55ff5 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
25f7a31 
…olbox into vikarant/bigdataBub
@vinuthakaranth
update
9f6602f 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
enus change
a890f19 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
create new comp for large counter data
5b18bdf 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add loading for bubble
8e2a220 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
loading update for local imp
4c46914 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
rem unwanted code in largecc
0c9d3c1 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
remove console log
4dbf3b9 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
lintfix
a4665ed 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
lintfix
ed44439 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
83c3912 
…olbox into vikarant/enableLogCounterfactuals

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update
a4ca045 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
f58cfb4 
…olbox into vikarant/enableLogCounterfactuals
@vinuthakaranth
update
d40e36c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
reset index
4106736 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add instance
4be0ddd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/enableLogCounterfactuals/dashboard/index.html

@vinuthakaranth
remove any
5cacd7f 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
2a32998 
…olbox into vikarant/enableLogCounterfactuals
@vinuthakaranth vinuthakaranth marked this pull request as ready for review January 13, 2023 19:35
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/enableLogCounterfactuals/dashboard/index.html

@vinuthakaranth
address comment
84cb101 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
8d40cd1 
…olbox into vikarant/enableLogCounterfactuals
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/enableLogCounterfactuals/dashboard/index.html

@vinuthakaranth
update
3c69402 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/enableLogCounterfactuals/dashboard/index.html

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) January 17, 2023 19:18
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/enableLogCounterfactuals/dashboard/index.html

@vinuthakaranth vinuthakaranth merged commit 5f6dd92 into main Jan 17, 2023
@vinuthakaranth vinuthakaranth deleted the vikarant/enableLogCounterfactuals branch January 17, 2023 21:14
@imatiach-msft imatiach-msft mentioned this pull request Jan 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinuthakaranth @romanlutz