improve error message for invalid features passed to matrix and tree views from API endpoint in dashboard #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
xuke444,
romanlutz,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
RubyZ10
approved these changes
Jan 19, 2023
gaugup
reviewed
Jan 19, 2023
raiwidgets/tests/responsibleai_dashboard/test_responsibleai_dashboard_input_erroranalysis.py
Show resolved
Hide resolved
raiwidgets/tests/responsibleai_dashboard/test_responsibleai_dashboard_input_erroranalysis.py
Show resolved
Hide resolved
imatiach-msft
force-pushed
the
ilmat/fix-rai-valueerror
branch
2 times, most recently
from
2bff4f2 to
c457e8c
Compare
imatiach-msft
force-pushed
the
ilmat/fix-rai-valueerror
branch
from
c457e8c to
b828708
Compare
…views from API endpoint in dashboard
imatiach-msft
force-pushed
the
ilmat/fix-rai-valueerror
branch
from
b828708 to
8c32d06
Compare
gaugup
approved these changes
Jan 19, 2023
1 similar comment
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API endpoint for erroranalysis tree and matrix views can fail if the features passed in don't exist. This PR improves the error message and adds tests.
Checklist