Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forecasting RAI dashboard: expand test data, add categorical what if #1921

Merged
merged 9 commits into from
Jan 25, 2023
Merged

Forecasting RAI dashboard: expand test data, add categorical what if #1921

merged 9 commits into from
Jan 25, 2023

Conversation

romanlutz
Copy link
Contributor

Description

This PR is the result of updates and fixes I made while building the Python backend side that matches the forecasting RAI UI portion. This includes:

  • expanding the test data shown in the test env to include a case with no features (which means What-if won't work as we can't change features) and a case with only a single time series (which means we can't choose from a set of time series) in addition to the existing case with 3 separate time series. The latter two cases now also have categorical features that can be changed.
  • adding support for changing categorical features to the What-if dialog. This prompted me to split up the logic into separate components since the contents are sufficiently different.
  • removing leftover occurrences of datetime_features (plural) by changing them to time_column_name (singular)
  • moving getRawValue function to JointDataset since it operates on the joint dataset anyway. We need this in order to convert values back and forth from UI to backend as we ask for forecasts.
  • handling case when there's only a single time series (= All data)
  • creating "What If section" as a separate component consisting of What-if button and the table of What-If transformations. This won't be visible if there are no features to change, so it encapsulates the What-if-only experience well.
  • small adjustments to cohort settings and shift view to reflect "time series" instead of "cohort" for forecasting tasks.

As mentioned before, e2e tests to follow in early February and certainly before making this available to anyone (date TBD).

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/forecasting_ui_updates/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/forecasting_ui_updates/dashboard/index.html

@romanlutz romanlutz enabled auto-merge (squash) January 25, 2023 21:39
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/romanlutz/forecasting_ui_updates/dashboard/index.html

@romanlutz romanlutz merged commit 1510f03 into main Jan 25, 2023
@romanlutz romanlutz deleted the romanlutz/forecasting_ui_updates branch January 25, 2023 22:56
RubyZ10 pushed a commit that referenced this pull request Feb 7, 2023
@romanlutz @RubyZ10
Forecasting RAI dashboard: expand test data, add categorical what if (#…
c4dd6bd 
…1921)

* add UI changes

* lintfix

* add example of operation method string

* add check for context

* add explanatory comment

* move description creation logic into getDescription

* lintfix

* remove datetime_features from snapshot

Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
@imatiach-msft imatiach-msft mentioned this pull request Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawestra hawestra hawestra approved these changes

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanlutz @hawestra