-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a limit on the number of samples used for computing global explanations #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lanations Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
January 25, 2023 19:32
gaugup
changed the title
Adding a limit on the number of samples used for computing global explanations
[WIP] Adding a limit on the number of samples used for computing global explanations
Jan 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #1924 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 93 93
Lines 4617 4621 +4
=======================================
+ Hits 4310 4314 +4
Misses 307 307
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
changed the title
[WIP] Adding a limit on the number of samples used for computing global explanations
Adding a limit on the number of samples used for computing global explanations
Jan 25, 2023
romanlutz
approved these changes
Jan 25, 2023
imatiach-msft
approved these changes
Jan 25, 2023
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
RubyZ10
pushed a commit
that referenced
this pull request
Feb 7, 2023
…lanations (#1924) * Adding a limit on the number of samples used for computing global explanations Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> * Increase the data limit to 10K Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> --------- Signed-off-by: Gaurav Gupta <gaugup@microsoft.com> Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a limit on the number of samples used for computing global explanations. Following is the table for the run time to compute global explanations:-
Hence, setting the limit to be 5000 for now to make the global explanations end-point as responsive as possible to the requests.
Checklist