Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a limit on the number of samples used for computing global explanations #1924

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Jan 25, 2023

Description

Adding a limit on the number of samples used for computing global explanations. Following is the table for the run time to compute global explanations:-

Test data rows Global explanation run time (seconds)
5000 1.89
10000 3.89
15000 5.92
20000 8.44
30000 14.20
40000 20.49

Hence, setting the limit to be 5000 for now to make the global explanations end-point as responsive as possible to the requests.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

…lanations

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@gaugup gaugup changed the title Adding a limit on the number of samples used for computing global explanations [WIP] Adding a limit on the number of samples used for computing global explanations Jan 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #1924 (30cb0d1) into main (8b3075e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1924   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          93       93           
  Lines        4617     4621    +4     
=======================================
+ Hits         4310     4314    +4     
  Misses        307      307           
Flag Coverage Δ
unittests 93.35% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ibleai/responsibleai/managers/explainer_manager.py 89.65% <100.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaugup gaugup changed the title [WIP] Adding a limit on the number of samples used for computing global explanations Adding a limit on the number of samples used for computing global explanations Jan 25, 2023
@gaugup gaugup enabled auto-merge (squash) January 27, 2023 23:49
@gaugup gaugup merged commit e15a9d4 into main Jan 28, 2023
@gaugup gaugup deleted the gaugup/SampleDataForExplanations branch January 28, 2023 01:43
RubyZ10 pushed a commit that referenced this pull request Feb 7, 2023
…lanations (#1924)

* Adding a limit on the number of samples used for computing global explanations

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

* Increase the data limit to 10K

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>

---------

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants