Unify responsibleai constants #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
gaugup,
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1925 +/- ##
===========================================
- Coverage 92.44% 63.92% -28.53%
===========================================
Files 103 13 -90
Lines 4871 158 -4713
===========================================
- Hits 4503 101 -4402
+ Misses 368 57 -311
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1 similar comment
romanlutz
force-pushed
the
romanlutz/refactor_rai_insights
branch
from
94b14db to
a9614e1
Compare
responsibleai/tests/counterfactual/test_counterfactual_advanced_features.py
Outdated
Show resolved
Hide resolved
imatiach-msft
approved these changes
Jan 27, 2023
1 similar comment
vinuthakaranth
approved these changes
Jan 27, 2023
| @@ -198,7 +199,8 @@ def test_loading_rai_insights_without_model_file(self): | |||
|
|
|||
| # Remove the model.pkl file to cause an exception to occur | |||
| # while loading the model. | |||
| model_pkl_path = Path(tmpdir) / "rai_insights" / "model.pkl" | |||
| model_pkl_path = Path(tmpdir) / \ | |||
| "rai_insights" / SerializationAttributes.MODEL_PKL | |||
There was a problem hiding this comment.
should this also be a const?
| explainer_pkl_path = \ | ||
| directory_manager.get_generators_directory() / "explainer.pkl" | ||
| explainer_pkl_path = ( | ||
| directory_manager.get_generators_directory() / |
| @@ -60,7 +61,7 @@ def test_causal_save_and_load(self, housing_data, tmpdir): | |||
| dm = DirectoryManager(parent_directory_path=save_dir, | |||
| sub_directory_name=causal_dir) | |||
| causal_analysis_pkl_file_path = \ | |||
| dm.get_data_directory() / "causal_analysis.pkl" | |||
| dm.get_data_directory() / ("causal_analysis" + FileFormats.PKL) | |||
There was a problem hiding this comment.
Oh I see, you are moving common ones in a file. These could be a const in their own file. May be not for this PR.
RubyZ10
pushed a commit
that referenced
this pull request
Feb 7, 2023
* use META_JSON directly instead of declaring a variable * move constants to common files and reuse * lowercase f * isort * use parentheses instead of backslashes * flake8 * isort Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a prerequisite to adding
RAIForecastingInsightsin the next PR. Having everything on a per-file basis was not very clean, so I decided to unify themChecklist