Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Large data feature importance] Add individual feature importance #1929

Merged
merged 56 commits into from
Feb 1, 2023
Merged

[Large data feature importance] Add individual feature importance #1929

merged 56 commits into from
Feb 1, 2023

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Jan 31, 2023 •
edited
Loading

Description

This PR has below changes:

  1. Adds feature importance for local explanations
  2. Initially bubble chart will be displayed for large data
  3. On clicking bubble - scatter plot will be displayed with points in the bubble
  4. On clicking each point - local explanations for that point will be displayed
  5. View as absolute values toggle
  6. Class importance weights based on model type
  7. Slider to change num. of features on highchart
  8. Revert to bubble chart when in scatter plot of a specific bubble

Individual feature importance for classification:
FIclassExp

Individual feature importance for multi classification:
FIMultiClassExp

Individual feature importance for regression:
FIRegressionExp

Not large data experience will remain the same:
FIIOldExp

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@vinuthakaranth
dasetEx changes
3f89967 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
enable log
4f95b1e 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
f9ee08b 
…olbox into vikarant/DELDPart1
@vinuthakaranth
isloading
babdb62 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
display err
61dd03d 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
revert button
caf3a5a 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
rem hide
bd37c2f 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
refine
690811c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
move
0b032d1 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
lintfix
0b1edd7 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
806c62c 
…olbox into vikarant/DELDPart1
@vinuthakaranth
lintfix
35fe399 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
rename
9475847 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
move chart area
f9c5bd9 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
CF use bub from core
e1b3f05 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
bub chart
e652eaa 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add localimp api
01b676c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
local exp
80b9c62 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
01b0fb7 
…olbox into vikarant/FeatureImportancePart1
@vinuthakaranth
add
a7cb6d5 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
changes
906185e 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
class weights
d477fe1 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
toggle
91997dd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
ch props
aa953d0 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update
fa214bd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
9856c99 
…olbox into vikarant/FeatureImportancePart1
@vinuthakaranth
state update
60e41d0 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
reset series
dba91d5 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add
76eb385 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
local axis name
490d63d 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
romanlutz
romanlutz reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big PR, so it's kind of hard to review. Will there be tests added at a later point?

libs/model-assessment/src/lib/ModelAssessmentDashboard/Controls/FeatureImportances.tsx Show resolved Hide resolved
...ndividualFeatureImportanceView/LargeIndividualFeatureImportanceView/LocalImportanceChart.tsx Outdated Show resolved Hide resolved
@vinuthakaranth
build fix
6105883 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
rename
8047c82 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/FeatureImportancePart1/dashboard/index.html

@vinuthakaranth
address comments
7c5a39a 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
6682a27 
…olbox into vikarant/FeatureImportancePart1
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/FeatureImportancePart1/dashboard/index.html

@vinuthakaranth
Copy link
Contributor Author

This is a pretty big PR, so it's kind of hard to review. Will there be tests added at a later point?

I agree, Thank a lot for reviewing!! large data flow is completely separate from existing flow for individual feature importance. All the related files are in separate folder. Yes, tests will be added at later point of time once we have all changes working.

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) February 1, 2023 17:46
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/FeatureImportancePart1/dashboard/index.html

@vinuthakaranth vinuthakaranth merged commit 1170331 into main Feb 1, 2023
@vinuthakaranth vinuthakaranth deleted the vikarant/FeatureImportancePart1 branch February 1, 2023 19:24
RubyZ10 pushed a commit that referenced this pull request Feb 7, 2023
@vinuthakaranth @RubyZ10
[Large data feature importance] Add individual feature importance (#1929
302b820 
)

* dasetEx changes

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* enable log

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* isloading

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* display err

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* revert button

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* rem hide

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* refine

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* move

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* lintfix

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* lintfix

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* rename

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* move chart area

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* CF use bub from core

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* bub chart

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* add localimp api

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* local exp

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* add

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* changes

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* class weights

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* toggle

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* ch props

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* update

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* state update

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* reset series

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* add

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* local axis name

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* update

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* add revert button

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* disable buttons

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* rem unw styles

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* fix toggle

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* reg check

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* topk slider

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* remove console

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* lintfix

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* lintfix

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* line limit

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* line c

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* lint limit

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* rem any

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* div to stack

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* lintfix

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* update

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>

* build fix

Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>

* rename

Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>

* address comments

Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>

---------

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
@imatiach-msft imatiach-msft mentioned this pull request Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz left review comments

@tongyu-microsoft tongyu-microsoft tongyu-microsoft approved these changes

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@hawestra hawestra Awaiting requested review from hawestra

@gaugup gaugup Awaiting requested review from gaugup gaugup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinuthakaranth @romanlutz @tongyu-microsoft