Deprecate categorical_features argument in favor of feature_metadata.categorical_features, improve metadata validation, and add forecasting-related metadata #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
requested review from
gaugup,
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
…olbox into romanlutz/categorical_features
Codecov Report
@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 93.27% 93.23% -0.05%
==========================================
Files 95 95
Lines 4657 4700 +43
==========================================
+ Hits 4344 4382 +38
- Misses 313 318 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaugup
reviewed
Feb 1, 2023
romanlutz
changed the title
gaugup
reviewed
Feb 2, 2023
responsibleai/tests/rai_insights/test_rai_insights_validations.py
Outdated
Show resolved
Hide resolved
…olbox into romanlutz/categorical_features
…r validation function
imatiach-msft
approved these changes
Feb 2, 2023
2 similar comments
gaugup
reviewed
Feb 2, 2023
tongyu-microsoft
approved these changes
Feb 2, 2023
RubyZ10
pushed a commit
that referenced
this pull request
Feb 7, 2023
…categorical_features, improve metadata validation, and add forecasting-related metadata (#1934) * feature metadata and categorical_features consolidation * fix serialization of feature metadata * fix tests * flake8 * tests for feature metadata and cat features * flake8 * fix string * datetime_features and time_series_id_features replacement * pytest.mark.skip * remaining ts id col names fix * fix failing test * fix docstrings * constants for feature purposes * revert validation function name to original and fix docstring of other validation function * flake8 * isort * undo workaround in feature metadata validation code * move feature metadata validation into a separate method * flake8 * add constants for strings * use set Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating the existing arg with a note to switch to
feature_metadata.categorical_features. After v0.26 we can remove it entirely. The reason I'm creating this is because the duplicate way of providing categorical features can cause all sorts of trouble if unhandled (which is currently the case).This PR also improves the validation code in
FeatureMetadataand adds forecasting-related fields liketime_column_nameandtime_series_id_column_names.Checklist