Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Large data individual causal] Add individual causal what-if to large data #1942

Merged
merged 37 commits into from
Feb 10, 2023
Merged

[Large data individual causal] Add individual causal what-if to large data #1942

merged 37 commits into from
Feb 10, 2023

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Feb 5, 2023 •
edited
Loading

Add individual causal what-if to large data

Description

This PR has below changes:

  1. Adds individual causal what-if to large data
  2. Initially bubble chart will be displayed for large data
  3. On clicking bubble - scatter plot will be displayed with points in the bubble
  4. On clicking each point - local causal for that point will be displayed
  5. In case of regression, user can select treatments and test data row will the queried from the backend and will be used to get what-if data.
  6. Revert to bubble chart when in scatter plot of a specific bubble

Regression:
CausalRegression

Classification:
CausalClassification

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

vinuthakaranth and others added 16 commits February 1, 2023 16:26
@vinuthakaranth
add g
76324ea 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
add local_causal api
2f7cae5 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
65f8da0 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
4cebb48 
…olbox into vikarant/CausalPart1
@vinuthakaranth
add
cc99d5c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add
abc55dd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update causal local
8b88174 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
on declick remove data
fba7cfd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
is loading
f064e77 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add revert button
dbd84e0 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add test data row
e74f375 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
test data row changes
fb5b4cf 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
f722b64 
…olbox into vikarant/CausalPart1
@vinuthakaranth
lintfix
b6dbf69 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
1699b3f 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'vikarant/CausalPart1' of https://github.com/microsoft/r…
db3233a 
…esponsible-ai-toolbox into vikarant/CausalPart1
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@vinuthakaranth
reduce lines in whatif
493a54d 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
max lines
55916cc 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
max lines
9be3532 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
37701c6 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'vikarant/CausalPart1' of https://github.com/microsoft/r…
2483aea 
…esponsible-ai-toolbox into vikarant/CausalPart1
@vinuthakaranth
lines
fdaa818 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update interface ICausalAnalysisData
78220e9 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
remove any
58c4af4 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add lint
0647886 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
2a4cc09 
…olbox into vikarant/CausalPart1
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@tongyu-microsoft
Copy link
Contributor

tongyu-microsoft commented Feb 8, 2023 •
edited
Loading

Can we update the styles of 'Revert to bubble chart' by adding top padding and change the button width a little bit to probably make it in one line?
image

@vinuthakaranth
Copy link
Contributor Author

Can we update the styles of 'Revert to bubble chart' by adding top padding and change the button width a little bit to probably make it in one line? image

Thanks Tong! I was trying to keep it same as dropdown width. I see counterfactuals has differnt width as well. So increased the width of the button.
image

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@vinuthakaranth
address comments
64a2d81 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
ce56108 
…olbox into vikarant/CausalPart1
@vinuthakaranth vinuthakaranth enabled auto-merge (squash) February 9, 2023 19:45
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/CausalPart1/dashboard/index.html

@vinuthakaranth vinuthakaranth merged commit 1f163af into main Feb 10, 2023
@vinuthakaranth vinuthakaranth deleted the vikarant/CausalPart1 branch February 10, 2023 02:50
@imatiach-msft imatiach-msft mentioned this pull request Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@tongyu-microsoft tongyu-microsoft tongyu-microsoft approved these changes

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinuthakaranth @tongyu-microsoft @romanlutz @imatiach-msft @xuke444