Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Large data] Map classification outcome to string values, dither, count changes #1955

Merged
merged 56 commits into from
Feb 15, 2023
Merged

[Large data] Map classification outcome to string values, dither, count changes #1955

merged 56 commits into from
Feb 15, 2023

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented Feb 8, 2023 •
edited
Loading

Description

This PR contains changes for below:

  1. Map classification outcome to string values (false positive, false negative, true positive & true negative) for data explorer, feature importance, counterfactuals.
  2. Disable dither for large data as it is handled in backend
  3. Remove count large data explorer individual points as size is already present as part of cluster
  4. Refactor code by creating interface IClusterData which has all the details of the cluster selected.

bubble plot retaining existing experience:
image

scatter plot with mapped values:
image

dither changes:
image

remove count:
image

bubble

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

vinuthakaranth and others added 30 commits February 1, 2023 16:26
@vinuthakaranth
add g
76324ea 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
add local_causal api
2f7cae5 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
65f8da0 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
4cebb48 
…olbox into vikarant/CausalPart1
@vinuthakaranth
add
cc99d5c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add
abc55dd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update causal local
8b88174 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
on declick remove data
fba7cfd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
is loading
f064e77 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add revert button
dbd84e0 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add test data row
e74f375 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
test data row changes
fb5b4cf 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
f722b64 
…olbox into vikarant/CausalPart1
@vinuthakaranth
lintfix
b6dbf69 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
1699b3f 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'vikarant/CausalPart1' of https://github.com/microsoft/r…
db3233a 
…esponsible-ai-toolbox into vikarant/CausalPart1
@vinuthakaranth
reduce lines in whatif
493a54d 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
max lines
55916cc 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
max lines
9be3532 
Signed-off-by: Vinutha Karanth <vikarant@microsoft.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
37701c6 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'vikarant/CausalPart1' of https://github.com/microsoft/r…
2483aea 
…esponsible-ai-toolbox into vikarant/CausalPart1
@vinuthakaranth
lines
fdaa818 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
update interface ICausalAnalysisData
78220e9 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
remove any
58c4af4 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add lint
0647886 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
2a4cc09 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'main' into vikarant/CausalPart1
db110c3
@vinuthakaranth
map, style and count
04f60dd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add xymap
a42af79 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
map to all comp
606103d 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/dataexplorerPart2/dashboard/index.html

@vinuthakaranth
address comments
64a2d81 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
ce56108 
…olbox into vikarant/CausalPart1
@vinuthakaranth
Merge branch 'vikarant/CausalPart1' of https://github.com/microsoft/r…
76bc6b4 
…esponsible-ai-toolbox into vikarant/dataexplorerPart2
@vinuthakaranth
counter fix
7e95476 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/dataexplorerPart2/dashboard/index.html

@vinuthakaranth
counterfactuals clusterdata
12af092 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
dataset cluster data
4d1b94b 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
get ini from core
0c56e7f 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
FI clusters
12d87fd 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
lintfix and causal
4f59797 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
rename new
80d7cce 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
261cc57 
…olbox into vikarant/dataexplorerPart2

Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
revert pckg fle
aa07c89 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth vinuthakaranth changed the title Please do not review for now - waiting for https://github.com/microsoft/responsible-ai-toolbox/pull/1942 to merge - [Large data] Map classification outcome to string values, dither, count changes [Large data] Map classification outcome to string values, dither, count changes Feb 10, 2023
@vinuthakaranth vinuthakaranth marked this pull request as ready for review February 10, 2023 03:16
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/dataexplorerPart2/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/dataexplorerPart2/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikarant/dataexplorerPart2/dashboard/index.html

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) February 14, 2023 23:10
@vinuthakaranth vinuthakaranth merged commit 7b14f56 into main Feb 15, 2023
@vinuthakaranth vinuthakaranth deleted the vikarant/dataexplorerPart2 branch February 15, 2023 19:08
@imatiach-msft imatiach-msft mentioned this pull request Mar 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongyu-microsoft tongyu-microsoft tongyu-microsoft approved these changes

@gaugup gaugup gaugup approved these changes

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinuthakaranth @gaugup @tongyu-microsoft