[Refactor]Add columnRanges and modelType to ModelAssessmentContext #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RubyZ10 <zhenzhu@microsoft.com>
RubyZ10
requested review from
imatiach-msft,
tongyu-microsoft,
xuke444,
vinuthakaranth,
romanlutz and
hawestra
as code owners
libs/model-assessment/src/lib/ModelAssessmentDashboard/utils/getModelTypeFromProps.ts
Show resolved
Hide resolved
tongyu-microsoft
approved these changes
Mar 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
columnRanges calculate the range for each feature and the other cohort filter columns. It will be used in cohort editor panel
and as chart axis values, etc
Both of them will be used in following refactor PRs.
Put them in context as they will be used cross components and should be global
Checklist