Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Big data] Few bug fixes and changes #2056

Merged
merged 18 commits into from
May 11, 2023
Merged

[Big data] Few bug fixes and changes #2056

merged 18 commits into from
May 11, 2023

Conversation

vinuthakaranth
Copy link
Contributor

@vinuthakaranth vinuthakaranth commented May 11, 2023 •
edited
Loading

Description

  1. Convert text 'Revert to bubble chart' to 'View bubble chart'
  2. Persist bubble plot data when axis doesn't change
  3. Add loading for global explanations and data analysis - aggregate
  4. Fix button text overflow issue

For aggregate importance and data explorer plot add loading:
loadingAgg

No bubble API call on 'View bubble plot'
nobubcall

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@vinuthakaranth
fix button overflow
0ee9f63 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
no bubble call on revert
57407a9 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
counter
8474e5d 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
dataexp
7fc54bf 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
causal
6f975f0 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
loading agg fp
cef52d0 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
add
4dd9ddb 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'vikarant/loading' into vikaarnt/bigDataChanges
dea635f
@vinuthakaranth
counterf
1d48c2a 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
Merge branch 'main' of https://github.com/microsoft/responsible-ai-to…
1fbfa12 
…olbox into vikaarnt/bigDataChanges
@vinuthakaranth
FI
229f9c4 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
DE
7d50e4c 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
updates
49b6272 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
lintfix
ea47450 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
lintf
38551eb 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth
DE loading
57ff03f 
Signed-off-by: vinutha karanth <vinutha.karanth@gmail.com>
@vinuthakaranth vinuthakaranth marked this pull request as ready for review May 11, 2023 00:08
@vinuthakaranth vinuthakaranth changed the title []Big data] Few bug fixes and changes [Big data] Few bug fixes and changes May 11, 2023
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikaarnt/bigDataChanges/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikaarnt/bigDataChanges/dashboard/index.html

@vinuthakaranth vinuthakaranth enabled auto-merge (squash) May 11, 2023 21:32
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/vikaarnt/bigDataChanges/dashboard/index.html

@vinuthakaranth vinuthakaranth merged commit 6d75178 into main May 11, 2023
@vinuthakaranth vinuthakaranth deleted the vikaarnt/bigDataChanges branch May 11, 2023 23:07
@imatiach-msft imatiach-msft mentioned this pull request Jun 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongyu-microsoft tongyu-microsoft tongyu-microsoft approved these changes

@gaugup gaugup gaugup approved these changes

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@romanlutz romanlutz Awaiting requested review from romanlutz

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinuthakaranth @imatiach-msft @gaugup @tongyu-microsoft