Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_valid_uuid to rai_test_utils #2061

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented May 15, 2023

Description

Looks like we try to validate if a string is a valid UUID in our tests. So adding is_valid_uuid to rai_test_utils to import from one common place.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #2061 (944947c) into main (d568f3b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
+ Coverage   92.33%   92.34%   +0.01%     
==========================================
  Files          98      100       +2     
  Lines        4957     4967      +10     
==========================================
+ Hits         4577     4587      +10     
  Misses        380      380              
Flag Coverage Δ
unittests 92.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ai_test_utils/rai_test_utils/utilities/__init__.py 100.00% <100.00%> (ø)
rai_test_utils/rai_test_utils/utilities/utils.py 100.00% <100.00%> (ø)

@gaugup gaugup enabled auto-merge (squash) May 17, 2023 18:50
@gaugup gaugup merged commit e083322 into main May 17, 2023
@gaugup gaugup deleted the gaugup/AddTestUTilitiesModule branch May 17, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants