Raise value error for min max computation of feature range #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kicha0
requested review from
gaugup,
imatiach-msft,
xuke444,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2072 +/- ##
=======================================
Coverage 92.42% 92.43%
=======================================
Files 101 101
Lines 5017 5022 +5
=======================================
+ Hits 4637 4642 +5
Misses 380 380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaugup
requested changes
May 22, 2023
1 similar comment
Hi, In the process of trying to troubleshoot we find missing exception information about the failure, this is exception handling (logging) for a case with unknown trigger condition. Could you suggest a suitable unit test for this as it's not clear what a dataset needs to look like in the first place to trigger a ValueError in this part. |
gaugup
reviewed
Jun 1, 2023
2 similar comments
gaugup
approved these changes
Jun 1, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising value error for exception in converting min / max of a feature column to float, and printing the type of the argument.
Description
Observed value error:
<class 'ValueError'>
File "/mnt/azureml/cr/j/[guid]/exe/wd/_telemetry/_loggerfactory.py", line 143 in wrapper
return func(*args, **kwargs)
File "create_rai_insights.py", line 184 in main
_ = RAIInsights(
File "/azureml-envs/responsibleai/lib/python3.8/site-packages/responsibleai/rai_insights/rai_insights.py", line 236 in init
self._feature_ranges = RAIInsights._get_feature_ranges(
File "/azureml-envs/responsibleai/lib/python3.8/site-packages/responsibleai/rai_insights/rai_insights.py", line 1263 in _get_feature_ranges
max_value = float(test[col].max())
Checklist