Correct test command and add clarification on GPG Key to CONTRIBUTING.md #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ziqi-ma
commented
May 24, 2023
ziqi-ma
commented
- Corrected e2e test command from yarn e2eall to yarn e2e
- Added clarification on setting up GPG Key
|
This is great! I see the commit is signed. Only issue is that it's from your own fork which will make CD fail. On the other hand we know that you only added to a md file so you couldn't have broken it... I will just bypass branch protections in this case, but please open PRs from the main repo in the future. I should have explained that and forgot, my bad! |
hawestra
added a commit
that referenced
this pull request
May 24, 2023
* fix outline bug and add contributors to readme * set text outline to none for all heatmaps * fix line limit * Correct test command and add clarification on GPG Key to CONTRIBUTING.md (#2082) --------- Co-authored-by: Ziqi Ma <ziqima@uchicago.edu>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.