Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Object Detection] Model Overview Cache Support Extension for torchmetrics #2170

Merged
merged 13 commits into from
Jul 13, 2023

Conversation

Advitya17
Copy link
Collaborator

This PR extends the OD cache support from #2158 as the torchmetrics API calculates the metrics for all classes at once, which are now all cached as part of this PR.

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@Advitya17 Advitya17 changed the title Agemawat/od cache ext [Object Detection] Model Overview Cache Support Extension for torchmetrics Jul 7, 2023
2 similar comments
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Merging #2170 (dac1bc2) into main (f3d8cbb) will decrease coverage by 9.79%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2170      +/-   ##
==========================================
- Coverage   88.13%   78.34%   -9.79%     
==========================================
  Files         129       26     -103     
  Lines        7296     2152    -5144     
==========================================
- Hits         6430     1686    -4744     
+ Misses        866      466     -400     
Flag Coverage Δ
unittests 78.34% <0.00%> (-9.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._vision/rai_vision_insights/rai_vision_insights.py 72.38% <0.00%> (ø)

... and 103 files with indirect coverage changes

@Advitya17 Advitya17 requested a review from imatiach-msft July 7, 2023 22:05
@Advitya17 Advitya17 enabled auto-merge (squash) July 12, 2023 14:12
@Advitya17 Advitya17 merged commit 5dc4159 into main Jul 13, 2023
@Advitya17 Advitya17 deleted the agemawat/od_cache_ext branch July 13, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants