-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry logic to image reader #2206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kicha0
requested review from
gaugup,
imatiach-msft,
RubyZ10,
vinuthakaranth,
tongyu-microsoft,
xuke444 and
hawestra
as code owners
August 2, 2023 18:18
Codecov Report
@@ Coverage Diff @@
## main #2206 +/- ##
==========================================
- Coverage 88.04% 78.22% -9.83%
==========================================
Files 129 26 -103
Lines 7303 2172 -5131
==========================================
- Hits 6430 1699 -4731
+ Misses 873 473 -400
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 similar comment
kicha0
force-pushed
the
kicha/main/retry
branch
2 times, most recently
from
August 2, 2023 19:04
6d23f2d
to
63275b1
Compare
1 similar comment
imatiach-msft
approved these changes
Aug 2, 2023
kicha0
force-pushed
the
kicha/main/retry
branch
2 times, most recently
from
August 2, 2023 21:22
770373c
to
0a5031d
Compare
1 similar comment
kicha0
force-pushed
the
kicha/main/retry
branch
from
August 2, 2023 21:33
1e69b51
to
881c409
Compare
kicha0
force-pushed
the
kicha/main/retry
branch
from
August 2, 2023 21:38
881c409
to
5cc36c7
Compare
3 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry logic to image reader
Description
Add retry logic to image reader for connection error, some retryable http status code in the 5xx
Checklist