Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry logic to image reader #2206

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add retry logic to image reader #2206

merged 2 commits into from
Aug 3, 2023

Conversation

kicha0
Copy link
Contributor

@kicha0 kicha0 commented Aug 2, 2023

Add retry logic to image reader

Description

Add retry logic to image reader for connection error, some retryable http status code in the 5xx

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #2206 (7f58d95) into main (b19a8fc) will decrease coverage by 9.83%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2206      +/-   ##
==========================================
- Coverage   88.04%   78.22%   -9.83%     
==========================================
  Files         129       26     -103     
  Lines        7303     2172    -5131     
==========================================
- Hits         6430     1699    -4731     
+ Misses        873      473     -400     
Flag Coverage Δ
unittests 78.22% <100.00%> (-9.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
..._vision/responsibleai_vision/utils/image_reader.py 70.58% <100.00%> (+10.06%) ⬆️

... and 103 files with indirect coverage changes

1 similar comment
@kicha0 kicha0 force-pushed the kicha/main/retry branch 2 times, most recently from 6d23f2d to 63275b1 Compare August 2, 2023 19:04
1 similar comment
@kicha0 kicha0 force-pushed the kicha/main/retry branch 2 times, most recently from 770373c to 0a5031d Compare August 2, 2023 21:22
@kicha0 kicha0 requested a review from romanlutz as a code owner August 2, 2023 21:22
1 similar comment
@kicha0 kicha0 force-pushed the kicha/main/retry branch from 1e69b51 to 881c409 Compare August 2, 2023 21:33
@kicha0 kicha0 force-pushed the kicha/main/retry branch from 881c409 to 5cc36c7 Compare August 2, 2023 21:38
3 similar comments
@kicha0 kicha0 enabled auto-merge (squash) August 3, 2023 04:59
@kicha0 kicha0 merged commit ebee56c into main Aug 3, 2023
@kicha0 kicha0 deleted the kicha/main/retry branch August 3, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants