Change ValueError to UserConfigValidationException in casual_manager.py
#2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ValueError` being raised is asking user to update the configuration. So this should be `UserConfigValidationException`.
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #2209 +/- ##
==========================================
+ Coverage 88.62% 92.24% +3.61%
==========================================
Files 117 103 -14
Lines 6376 5142 -1234
==========================================
- Hits 5651 4743 -908
+ Misses 725 399 -326
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaugup
changed the title
ValueError to UserConfigValidationExceptionValueError to UserConfigValidationException in casual_manager.py
RubyZ10
approved these changes
Aug 2, 2023
romanlutz
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ValueErrorbeing raised is asking user to update the configuration. So this should beUserConfigValidationException.Description
Checklist