Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input type validation for FeatureMetadata class #2218

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 4, 2023

Description

It could be so if these type validations are not in place, we might see weird failures in the code.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #2218 (670068b) into main (5eced64) will increase coverage by 4.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
+ Coverage   88.07%   92.56%   +4.49%     
==========================================
  Files         129       55      -74     
  Lines        7319     2125    -5194     
==========================================
- Hits         6446     1967    -4479     
+ Misses        873      158     -715     
Flag Coverage Δ
unittests 92.56% <ø> (+4.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 74 files with indirect coverage changes

1 similar comment
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should help raise some issues in a clearer way.

responsibleai/responsibleai/feature_metadata.py Outdated Show resolved Hide resolved
@gaugup gaugup enabled auto-merge (squash) August 9, 2023 22:51
1 similar comment
@gaugup gaugup merged commit 9908fc4 into main Aug 10, 2023
@gaugup gaugup deleted the gaugup/AddTypeValidationsFeatureMetadata branch August 10, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants