Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heatmap e2e test #2239

Merged
merged 30 commits into from
Sep 6, 2023
Merged

Heatmap e2e test #2239

merged 30 commits into from
Sep 6, 2023

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Aug 11, 2023 •
edited
Loading

Heatmap test for checking rgb color

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

romanlutz
romanlutz approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Any chance the common code can be put in a function?

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

5 similar comments
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@Advitya17 Advitya17 force-pushed the agemawat/hm_toggle_test branch from 536dce0 to 85133f0 Compare September 1, 2023 13:40
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

2 similar comments
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@Advitya17 Advitya17 marked this pull request as ready for review September 5, 2023 15:21
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/hm_toggle_test/dashboard/index.html

@Advitya17 Advitya17 merged commit 48309b0 into main Sep 6, 2023
@Advitya17 Advitya17 deleted the agemawat/hm_toggle_test branch September 6, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@hawestra hawestra Awaiting requested review from hawestra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Advitya17 @romanlutz