Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass categorical features after dropping dropped features in CounterfactualManager #2241

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

gaugup
Copy link
Contributor

@gaugup gaugup commented Aug 11, 2023

Description

It seems we are passing categorical_features without dropping the dropped features from it.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

…actualManager

It seems we are passing categorical_features without dropping the dropped features from it.
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #2241 (06d96a4) into main (ebbae9c) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   92.55%   92.26%   -0.30%     
==========================================
  Files          55      103      +48     
  Lines        2137     5169    +3032     
==========================================
+ Hits         1978     4769    +2791     
- Misses        159      400     +241     
Flag Coverage Δ
unittests 92.26% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...sibleai/responsibleai/rai_insights/rai_insights.py 87.74% <ø> (ø)

... and 47 files with indirect coverage changes

1 similar comment
@gaugup gaugup enabled auto-merge (squash) August 16, 2023 21:47
@gaugup gaugup merged commit 2c9899f into main Aug 16, 2023
@gaugup gaugup deleted the gaugup/PassCorrectCategoricalFeatures branch August 16, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants