Turn off flag should_construct_pandas_query in PredictionsModelWrapperClassification
#2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pperClassification` Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
imatiach-msft,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2277 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 103 103
Lines 5198 5198
=======================================
Hits 4845 4845
Misses 353 353
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Can you add a PR description. What motivated this change? |
romanlutz
approved these changes
Aug 24, 2023
vinuthakaranth
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
should_construct_pandas_queryparameter avoids usingquery()function to search in pandas dataframe.query()function call is slower than the alternativeiloc.Checklist