Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EA ModelTask Fix #2316

Merged
merged 1 commit into from
Sep 5, 2023
Merged

EA ModelTask Fix #2316

merged 1 commit into from
Sep 5, 2023

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Sep 5, 2023

Surfacing OD model task due to a hybrid use-case (compared to pure classification/regression) led to error in the next PR's gate - https://github.com/microsoft/responsible-ai-toolbox/actions/runs/6088815908/job/16520267568?pr=2233

This PR fixes that for the other image scenarios by pegging them to a pure classification scenario for the purposes of Error Analysis.

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #2316 (92eed75) into main (98f1640) will decrease coverage by 1.72%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
- Coverage   92.38%   90.66%   -1.72%     
==========================================
  Files         107       59      -48     
  Lines        5381     2324    -3057     
==========================================
- Hits         4971     2107    -2864     
+ Misses        410      217     -193     
Flag Coverage Δ
unittests 90.66% <80.00%> (-1.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ranalysis/erroranalysis/analyzer/error_analyzer.py 92.07% <66.66%> (-0.43%) ⬇️
erroranalysis/erroranalysis/_internal/constants.py 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

@Advitya17 Advitya17 enabled auto-merge (squash) September 5, 2023 22:45
@Advitya17 Advitya17 disabled auto-merge September 5, 2023 22:45
@Advitya17 Advitya17 enabled auto-merge (squash) September 5, 2023 22:50
@Advitya17 Advitya17 merged commit 6055a87 into main Sep 5, 2023
@Advitya17 Advitya17 deleted the agemawat/ea_image_modeltask branch September 5, 2023 22:56
@Advitya17 Advitya17 mentioned this pull request Sep 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants