fix failing object detection e2e jupyter notebook UI tests on linux #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
vinuthakaranth,
tongyu-microsoft,
romanlutz,
RubyZ10,
xuke444 and
hawestra
as code owners
gaugup
approved these changes
Sep 15, 2023
Advitya17
approved these changes
Sep 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix failing object detection e2e jupyter notebook UI tests on linux
seeing failing object detection unit tests on linux:
however on windows these seem to pass as there are indeed 3 and not 2 cohorts generated when selecting mean_pixel_value in the unit tests to generate the feature cohorts for object detection. This seems to be a numerical difference caused by the packages installed on the operating systems. Adding a special helper function for tests and conditionally setting the expected value based on the OS.
Note: these errors are currently causing other PRs to be blocked due to consistent build failures like #2337
Checklist