Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Analysis Label Fix for OD #2365

Merged
merged 21 commits into from
Sep 29, 2023
Merged

Data Analysis Label Fix for OD #2365

merged 21 commits into from
Sep 29, 2023

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Sep 27, 2023

Description

Before:

image

After:

image

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #2365 (078cb0f) into main (cfe1037) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 078cb0f differs from pull request most recent head e1d7c11. Consider uploading reports for the commit e1d7c11 to get more accurate results

@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   88.43%   88.48%   +0.05%     
==========================================
  Files         134      134              
  Lines        7685     7685              
==========================================
+ Hits         6796     6800       +4     
+ Misses        889      885       -4     
Flag Coverage Δ
unittests 88.48% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
responsibleai/responsibleai/_interfaces.py 100.00% <100.00%> (ø)
..._vision/rai_vision_insights/rai_vision_insights.py 77.28% <100.00%> (+0.70%) ⬆️

1 similar comment
1 similar comment
1 similar comment
1 similar comment
@Advitya17 Advitya17 marked this pull request as ready for review September 28, 2023 22:25
@imatiach-msft
Copy link
Contributor

@Advitya17 Can you please improve the description? I can't quite tell what the fix is for, and the images have no text describing whether it's before/after the fix or something else or any circle/square focusing in on what the changes were.

@Advitya17
Copy link
Collaborator Author

@Advitya17 Can you please improve the description? I can't quite tell what the fix is for, and the images have no text describing whether it's before/after the fix or something else or any circle/square focusing in on what the changes were.

@imatiach-msft added!

1 similar comment
1 similar comment
@Advitya17 Advitya17 merged commit 7206fe1 into main Sep 29, 2023
@Advitya17 Advitya17 deleted the agemawat/da_labels branch September 29, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants