fix choose cohorts close or cancel updating feature cohorts selection in flyout #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
romanlutz,
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
vinuthakaranth
approved these changes
Sep 28, 2023
|
|
||
| import { ErrorCohort } from "@responsible-ai/core-ui"; | ||
|
|
||
| export interface IChartConfigurationFlyoutProps { |
There was a problem hiding this comment.
nit: both props and state interface can be in single file
There was a problem hiding this comment.
or can be moved to utils file too
There was a problem hiding this comment.
we have 24 files that are props only:
https://github.com/search?q=repo%3Amicrosoft%2Fresponsible-ai-toolbox+Props.ts&type=code
and we have 12 files that are state only:
https://github.com/search?q=repo%3Amicrosoft%2Fresponsible-ai-toolbox+State.ts&type=code
I hope it's ok to keep to this convention? I just wanted to bring the line count down and this was the only thing I could think of. Seems it needs deeper refactoring to bring it below the suggested limit of 300 lines.
...nt/src/lib/ModelAssessmentDashboard/Controls/ModelOverview/ChartConfigurationFlyoutUtils.tsx
Outdated
Show resolved
Hide resolved
imatiach-msft
force-pushed
the
ilmat/fix-cohorts-close-save
branch
from
0bcd725 to
66b2d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing bug from bug bash discovered by @vinuthakaranth
The "Choose cohorts" flyout was saving the user's selection even when they clicked cancel or close buttons.
This issue was found during text/vision dashboard bugbash but it looks like a general issue that is in the tabular dashboard as well.
Video of functionality prior to fix:
rai_text_job.-.Azure.AI._.Machine.Learning.Studio.-.Work.-.Microsoft.Edge.2023-09-27.10-32-14.mp4
Video of functionality after fix:
Dashboard.-.Work.-.Microsoft.Edge.2023-09-27.10-33-49.mp4
Checklist