Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table View Search Fix for Multilabel & OD #2367

Merged
merged 9 commits into from
Oct 2, 2023
Merged

Table View Search Fix for Multilabel & OD #2367

merged 9 commits into from
Oct 2, 2023

Conversation

Advitya17
Copy link
Collaborator

@Advitya17 Advitya17 commented Sep 27, 2023 •
edited
Loading

Description

Initially:

image

image

With this fix:

image

image

image

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

@Advitya17 Advitya17 changed the title Table View Search Fix for Multilabel Table View Search Fix for Multilabel & OD Sep 29, 2023
@Advitya17 Advitya17 marked this pull request as ready for review September 29, 2023 18:39
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

1 similar comment
@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

@github-actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/agemawat/table_search/dashboard/index.html

@Advitya17 Advitya17 merged commit fef4248 into main Oct 2, 2023
@Advitya17 Advitya17 deleted the agemawat/table_search branch October 2, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatiach-msft imatiach-msft imatiach-msft approved these changes

@gaugup gaugup Awaiting requested review from gaugup gaugup is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

@RubyZ10 RubyZ10 Awaiting requested review from RubyZ10 RubyZ10 is a code owner

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@hawestra hawestra Awaiting requested review from hawestra

@romanlutz romanlutz Awaiting requested review from romanlutz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Advitya17 @imatiach-msft