-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional support for IS_CROWD for OD COCO label format #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
===========================================
- Coverage 89.09% 78.94% -10.15%
===========================================
Files 122 26 -96
Lines 6732 2280 -4452
===========================================
- Hits 5998 1800 -4198
+ Misses 734 480 -254
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1 similar comment
imatiach-msft
approved these changes
Oct 30, 2023
شكرا لك على المساعدة انا اوافق على السحب
في الاثنين، 30 أكتوبر 2023 في 10:12 م تمت كتابة ما يلي بواسطة Ilya
Matiach ***@***.***>:
… ***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#2395 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDQ7ZEJPMYPBJ4GH7U2RYYDYB732BAVCNFSM6AAAAAA6PQNIBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBUHA4TOMBYGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for the below stack trace with OD labels without IS_CROWD key:
<class 'KeyError'>
File "./rai_vision_insights.py", line 456 in main
rai_vi = RAIVisionInsights(
File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/rai_vision_insights/rai_vision_insights.py", line 239 in init
test = transform_object_detection_labels(
File "/azureml-envs/responsibleai-vision/lib/python3.8/site-packages/responsibleai_vision/utils/image_utils.py", line 134 in transform_object_detection_labels
int(label[IS_CROWD])])
Making it optional instead of removing it, due to significance (and potential support in future) for use-cases with crowds of people: AlexeyAB/darknet#5567 (comment)
Checklist