make elements under image explorer view tab keyboard accessible #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
tongyu-microsoft,
xuke444,
RubyZ10,
vinuthakaranth and
hawestra
as code owners
tongyu-microsoft
approved these changes
Nov 21, 2023
Advitya17
approved these changes
Nov 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for accessibility bug:
[Programmatic access - Responsible AI Dashboard – Vision Data Explorer>Image Explorer View]: Elements that have scrollable content under "Image explorer view" tab are not accessible by keyboard.
Users who rely on the keyboard for navigation will get impacted and miss the functionality of the control if the "Success Instances" section that has scrollable image contents under the "Image explorer view" tab are not accessible by keyboard.
Repro steps:
1.) Navigate the "Vision Data Explorer" section, navigate the "Image Explorer View" tab and all the controls present under it.
2.) Navigate to all the Image controls present under the "Success Instances" section.
3.) Observe and weather Elements that have scrollable content under "Image explorer view" tab are accessible by keyboard or not.
Checklist