Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aria label for screen reader on scatter plot color axis picker #2440

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

imatiach-msft
Copy link
Contributor

Description

fix aria label for screen reader on scatter plot color axis picker

[Screen reader – Responsible AI Dashboard – Vision Dashboard>Data analysis]: Screen reader does not announce the associated label information when focus lands on the "Predicted Y" button.

User Experience:
Visually impaired people who depend on screen readers for navigation will get impacted if screen reader does not announce the associated text information for the button. Due to this the end user will find difficulty in identifying the purpose of the button.

Note: User credentials should NOT be included in the bug.

Pre-Requisite: Turn on the screen reader (NVDA)
Repro Steps:
Open RAI dashboard
Navigate to the "Data analysis" section and select the 'Chart view' tab.
Select "Individual data points" radio button present under 'Chart type' and navigate using tab key.
Observe whether the screen reader announces the associated label information when focus lands on the "Predicted Y" button or not.
Actual Result:
Screen reader does not announce the associated label information when focus lands on the "Predicted Y" button.

Observation:
When focus lands on the "Predicted Y" button, the screen reader announces as "Predicted Y" button.
Narrator and JAWS do not announce the associated label information when focus lands on the "Predicted Y" button.
Expected Result:
Screen reader should announce the associated label information when focus lands on the "Predicted Y" button.

Example: When focus lands on the "Predicted Y" button, the screen reader should announce as "Color value - Predicted Y" button.

image

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft merged commit fe02419 into main Dec 6, 2023
65 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/fix-predicted-y-button-accessibility branch December 6, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants