fix tooltip callout keyboard focus order for accessibility #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
RubyZ10
approved these changes
Dec 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix tooltip callout keyboard focus order for accessibility
[Keyboard navigation – Responsible AI Dashboard – Vision Dashboard>Data analysis]: Keyboard focus order is not logical while navigating using tab key after expanding "Data analysis" tooltip.
User Experience:
People who depend on keyboard for navigation will get impacted if focus order is not logical while navigating using tab key as the focus moves out of the page. Due to this, the end user requires more keystrokes to regain the focus in forward navigation.
Repro Steps:
Open ResponsibleAI Dashboard
Navigate to the "Data analysis" section.
Expand the "Data analysis" info button and press tab key.
Observe whether keyboard focus is on logical order or not.
Actual Result:
Keyboard focus order is not logical while navigating using tab key after expanding "Data analysis" tooltip.
Observation:
After expanding the "Data analysis" info button, the screen reader announces as "Dialog - Select a datapoint by clicking on a datapoint (up to 5 datapoints) in the table to view their local feature importance values (local explanation) and individual conditional expectation (ICE) plots", and by pressing tab key, focus moves out of the page.
Expected Result:
Keyboard focus order should be on logical while navigating using tab key after expanding "Data analysis" tooltip.
Example: After expanding the "Data analysis" info button and by pressing tab key, either the keyboard focus should remain on the tooltip, or the focus should land on the next interactive element.
Note: Tab stops is not working.
Video of broken tab order:
TabOrderBroken.mp4
Video of fixed tab order (note now user has to press escape but they won't tab out to the browser window buttons):
TabOrderFixed.mp4
For more info see related fluentui issue on FocusTrapCallout:
microsoft/fluentui#1597
Checklist