upgrade plotly to latest version 2.27.1 #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
xuke444,
tongyu-microsoft,
vinuthakaranth,
RubyZ10 and
hawestra
as code owners
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
2 times, most recently
from
c14a077 to
93b585f
Compare
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
2 times, most recently
from
1613c87 to
4903762
Compare
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
2 times, most recently
from
f864dd9 to
f40ec18
Compare
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
2 times, most recently
from
070c668 to
890337c
Compare
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
2 times, most recently
from
59140dd to
7cffa1b
Compare
2 similar comments
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
5 times, most recently
from
ce2e2c6 to
cfcdbfe
Compare
1 similar comment
1 similar comment
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
9 times, most recently
from
77fe80e to
1b8854b
Compare
4 similar comments
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
2 times, most recently
from
57f1536 to
74110c5
Compare
1 similar comment
imatiach-msft
force-pushed
the
ilmat/upgrade-plotly
branch
from
74110c5 to
f1a18aa
Compare
hawestra
approved these changes
Jan 10, 2024
kartikc727
pushed a commit
to kartikc727/responsible-ai-toolbox
that referenced
this pull request
Jan 11, 2024
imatiach-msft
added a commit
that referenced
this pull request
Jan 11, 2024
…upt (#2486) * Added info about required packages * Update responsibleaidashboard-question-answering-model-debugging.ipynb * show example prediction * Update responsibleaidashboard-question-answering-model-debugging.ipynb * fix retry func not stopping for long time after sending interrupt * add fallback for non-integer delay * add tests for retry func fix * fix flake8 issues in test functions * fix import order on test_retry_func Signed-off-by: Kartik Choudhary <kartikchoudh@umass.edu> * fix retry func not stopping for long time after sending interrupt * add fallback for non-integer delay * add tests for retry func fix * fix flake8 issues in test functions * fix import order on test_retry_func Signed-off-by: Kartik Choudhary <kartikchoudh@umass.edu> * upgrade plotly to latest version 2.27.1 (#2484) --------- Signed-off-by: Kartik Choudhary <kartikchoudh@umass.edu> Co-authored-by: Ilya Matiach <ilmat@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade plotly to latest version 2.27.1
This involved updating some plotly code and also d3 packages.
Note after updating plotly and d3, some tests started failing due to issue with importing d3:
https://stackoverflow.com/questions/69075510/jest-tests-failing-on-d3-import
The suggested fix in the stackoverflow to use transformIgnorePatterns in the jest.config files was applied and resolved the issue.
I also tried updating jest but I ran into issues with nx, and then I tried to update nx but that ran into a lot of other issues. Hence, this current approach seems to be the best one for upgrading plotly.
For future context, this was the issue with jest and nx which led me to abandoning the approach of also upgrading nx and jest (in which case I think I wouldn't need to add the transformIgnorePatterns):
nrwl/nx#5873
Checklist