Add user feedback to compute() function #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaugup
requested review from
imatiach-msft,
gregorybchris and
xuke444
and removed request for
imatiach-msft and
gregorybchris
|
Weren't we planning to get rid of the |
responsibleai/responsibleai/_managers/error_analysis_manager.py
Outdated
Show resolved
Hide resolved
With or without comoute() this prints some useful information time taken. We can add more things to the decorator. |
imatiach-msft
approved these changes
Nov 18, 2021
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #697 +/- ##
==========================================
+ Coverage 92.37% 92.42% +0.05%
==========================================
Files 100 101 +1
Lines 4984 5017 +33
==========================================
+ Hits 4604 4637 +33
Misses 380 380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
1 similar comment
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
Signed-off-by: Gaurav Gupta <gaugup@microsoft.com>
gaugup
requested review from
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Also add the time taken in each compute() function.
The output looks like below:-