Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong latest version of package when running go mod tidy #714

Closed
alexcastilio opened this issue Sep 9, 2024 · 2 comments · Fixed by #996
Closed

Wrong latest version of package when running go mod tidy #714

alexcastilio opened this issue Sep 9, 2024 · 2 comments · Fixed by #996

Comments

@alexcastilio
Copy link
Contributor

Describe the bug
I tried to import github.com/microsoft/retina in my go code and when I ran go mod tidy, I got latest version (v0.10.0) which is not right, since latest is v0.0.16

To Reproduce
create a go package
import github.com/microsoft/retina
run go mod tidy
check go.mod: require github.com/microsoft/retina v0.10.0

Expected behavior
After run go mod tidy, check go.mod: require github.com/microsoft/retina v0.0.16

Screenshots
Screenshot of pkg.go.dev where latest version is also shown as v0.10.0:
image

Platform (please complete the following information):

  • OS: [e.g. AzureLinux]
  • Kubernetes Version: [e.g. 1.22]
  • Host: [e.g. AKS, KIND, self-host, etc]
  • Retina Version:

Additional context
Add any other context about the problem here.
@rbtr
Copy link
Collaborator

rbtr commented Sep 9, 2024

that one was supposed to be v0.0.10 😢 i thought it was cleaned up fast enough but seems not. i guess we should shift to incrementing the minor ver so that this isn't an issue until v1.0

@kamilprz kamilprz mentioned this issue Nov 5, 2024
Closed
@rbtr
Copy link
Collaborator

rbtr commented Nov 6, 2024

https://pkg.go.dev/about#removing-a-package
maybe we can fix this? @kamilprz @alexcastilio

@nddq nddq mentioned this issue Nov 12, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 12, 2024
@nddq
fix: add retract directive for v0.10.0 (#996)
8c3965d 
# Description

Add retract directive for v0.10.0, which was published accidentally.
## Related Issue

Closes #714 

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
@rbtr rbtr closed this as completed in #996 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Retina Triage Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add retract directive for v0.10.0 microsoft/retina
2 participants
@rbtr @alexcastilio