Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use mariner core base image for kubectl-retina #1027

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mainred
Copy link
Contributor

@mainred mainred commented Nov 19, 2024

Description

mariner distroless minimal provides no support to copy the kubectl-retina image from the container. We need more powerful base image to provide command like

          command:
          - sh
          - -c
          - cp -L /kubectl-retina /opt/tools/bin

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Signed-off-by: Qingchuan Hao <qingchuan.hao@microsoft.com>
@mainred mainred requested a review from a team as a code owner November 19, 2024 06:52
@SRodi SRodi added this pull request to the merge queue Nov 19, 2024
Merged via the queue into microsoft:main with commit 09951b7 Nov 19, 2024
26 checks passed
rbtr added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants