Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Run e2e tests in both arm64 and amd64 arch. #1129

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

jimassa
Copy link
Contributor

@jimassa jimassa commented Dec 11, 2024

Description

This PR allows us to run plugin e2e in both arm64 and amd64 arch.
It also replaces agnhost image with the standard one hosted in registry.k8s.io/e2e-test-imagesinstead of the fork in acnpublic, as it is multi-arch and good practice.

The test sets up agnhost in different args, and check plugin metrics on retina-agent on both amd64 and arm64.

image

image

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

#450

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 suggestion.

Files not reviewed (1)
  • test/e2e/common/common.go: Evaluated as low risk

@jimassa jimassa added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@jimassa jimassa added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@jimassa jimassa added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 1566b98 Dec 13, 2024
52 checks passed
@jimassa jimassa deleted the jmassa/e2e_arm_win branch December 13, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants