fix(lint-ci): Removing golang-lint govet deprecated parameter #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apontejaj
changed the title
|
Your deep link to the docs appears broken. Can you quote the section in a comment to understand what these options do, and why this is the correct new configuration? |
Link fixed in description. |
|
@timraymond |
timraymond
reviewed
Feb 18, 2025
timraymond
approved these changes
Feb 18, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
BeegiiK
pushed a commit
to BeegiiK/retina
that referenced
this pull request
Feb 28, 2025
…oft#1359) # Description After [deps: bump github.com/golangci/golangci-lint from 1.64.2 to 1.64.5 in /hack/tools](microsoft@f4d8f16), all PR started failing the golangci-lint workflow. This PR removes a parameter that has been deprecated by golanci-lint. ## Related Issue No issue created. ## Checklist - [X] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [X] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [X] I have correctly attributed the author(s) of the code. - [X] I have tested the changes locally. - [X] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed See workflow below.  ## Additional Notes Syntax updated as per golang-lint documentation https://golangci-lint.run/usage/linters/#govet   https://github.com/golangci/golangci-lint/blob/a8b68a590a88bbde93b27f8bf02031cb1db78b2b/pkg/config/loader.go#L402-L407  --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After deps: bump github.com/golangci/golangci-lint from 1.64.2 to 1.64.5 in /hack/tools, all PR started failing the golangci-lint workflow.
This PR removes a parameter that has been deprecated by golanci-lint.
Related Issue
No issue created.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
See workflow below.
Additional Notes
Syntax updated as per golang-lint documentation
https://golangci-lint.run/usage/linters/#govet
https://github.com/golangci/golangci-lint/blob/a8b68a590a88bbde93b27f8bf02031cb1db78b2b/pkg/config/loader.go#L402-L407
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.