Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CONTRIBUTING #210

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix: Update CONTRIBUTING #210

merged 2 commits into from
Apr 4, 2024

Conversation

timraymond
Copy link
Member

This updates CONTRIBUTING to include information about commit signing and the DCO.

Fixes #197

@timraymond timraymond requested a review from a team as a code owner April 2, 2024 18:38
@rbtr rbtr added the area/documentation Improvements or additions to documentation label Apr 2, 2024
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: this should have been an approval

@rbtr rbtr enabled auto-merge April 2, 2024 19:41
@rbtr rbtr self-requested a review April 3, 2024 19:31
@rbtr
Copy link
Collaborator

rbtr commented Apr 3, 2024

@timraymond please 😭
image

@rbtr rbtr added type/enhancement New feature or request priority/1 P1 labels Apr 3, 2024
@timraymond timraymond force-pushed the traymond/docs/contrib branch from 3155358 to e76a056 Compare April 4, 2024 21:33
This generally makes it easier to follow modifications in the document.
Furthermore, it makes it obvious when sentences are too long.
This adds information on Cryptographic Signing of Commits as well as
adding a Signed-off-by trailer to commits.

Fixes: #197
@timraymond timraymond force-pushed the traymond/docs/contrib branch from e76a056 to 1e7aa5a Compare April 4, 2024 21:38
@rbtr rbtr added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 815ae85 Apr 4, 2024
21 checks passed
@rbtr rbtr deleted the traymond/docs/contrib branch April 4, 2024 23:13
nddq pushed a commit that referenced this pull request May 6, 2024
This updates CONTRIBUTING to include information about commit signing
and the DCO.

Fixes #197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation priority/1 P1 type/enhancement New feature or request
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

Make Signing and Signed-off-By requirements clear in Contributing docs and README
2 participants