fix(bug): update scrapeConfig to filer retina container specifically #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRodi
force-pushed
the
fix/unhealthy-prom-target
branch
from
1a22a79 to
94ebdcb
Compare
rbtr
approved these changes
Sep 23, 2024
SRodi
force-pushed
the
fix/unhealthy-prom-target
branch
from
94ebdcb to
c6f3ead
Compare
Signed-off-by: Simone Rodigari <srodigari@microsoft.com>
SRodi
force-pushed
the
fix/unhealthy-prom-target
branch
from
c6f3ead to
e1fd50e
Compare
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
# Description Adding a ServiceMonitor for retina-operator * parameterized & applied retina-operator name * adding service & serviceMonitor CRD's for retina-operator * applied appropriate relabeling & metric relabeling config to align with retina-jobs additional scrape config ## Related Issue retina-operator wasn't being scraped for metrics by prometheus. Initially it was appearing in the 'retina-pods' job and failing as reported in this issue: #738 Partial fix was merged to remove the operator pod from the list here: #770 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed  Operator specific metrics with job='retina-operator' selector:  ## Additional Notes Proposed next steps is to align the way we add scrap configs: #847 --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
retina(retina agent)Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
fix #177
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Deployed unmanaged Prometheus as per doc instructions, see here
The target for retina-operator is no longer appearing since it is no longer scraped
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.