Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set PowerShell path using environment variables #850

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

xiaozhiche320
Copy link
Contributor

Description

Kusto complain the system cannot find the powershell path in Windows, I noticed in windows we are currently hardcoding the powershell path in hpc folder, since the windows powershell in PATH environment variable lost issue was fixed, we should change it back instead of hard code the path

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@xiaozhiche320 xiaozhiche320 requested a review from a team as a code owner October 11, 2024 14:38
@huntergregory
Copy link
Contributor

Hi @xiaozhiche320, thanks for raising this PR. Can you attach screenshots of before vs. after?

@xiaozhiche320
Copy link
Contributor Author

Hi @xiaozhiche320, thanks for raising this PR. Can you attach screenshots of before vs. after?

Hi Hunter, the screen are listed as below:
I add some context when testing if retina-win image work correctly, the work directory and the powershell env variable exist in both win-2019 and win-2022 Azure Container and it failed here for windows 2019
before
After (just set the time stamp from 10 min to 1 min and check if the call worked correctly)
image

@xiaozhiche320 xiaozhiche320 self-assigned this Oct 11, 2024
@xiaozhiche320 xiaozhiche320 removed the request for review from ritwikranjan October 16, 2024 13:27
@xiaozhiche320 xiaozhiche320 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into microsoft:main with commit 090a717 Oct 18, 2024
22 checks passed
@xiaozhiche320 xiaozhiche320 deleted the win_pwl branch October 18, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants