Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update doc, codespaces config and GHA on commit GPG signed #860

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Oct 15, 2024

Description

  • update contributing doc to add a note about signing commits by default
  • add instructions for codespaces users to use GPG to sign commits

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Signed-off-by: Simone Rodigari <srodigari@microsoft.com>
@SRodi SRodi requested a review from a team as a code owner October 15, 2024 13:05
Signed-off-by: Simone Rodigari <srodigari@microsoft.com>
kamilprz
kamilprz previously approved these changes Oct 15, 2024
docs/07-Contributing/developing.md Outdated Show resolved Hide resolved
docs/07-Contributing/developing.md Outdated Show resolved Hide resolved
@SRodi SRodi requested a review from timraymond October 15, 2024 18:15
@SRodi SRodi force-pushed the fix/docs branch 6 times, most recently from e95e0a0 to 8491444 Compare October 16, 2024 08:56
@SRodi SRodi requested review from rbtr and kamilprz October 16, 2024 09:07
@SRodi SRodi changed the title fix(docs): adjust contributing doc, clarify git commit requirements fix(docs): update doc, codespaces config and GHA on commit GPG signed Oct 16, 2024
@SRodi SRodi force-pushed the fix/docs branch 6 times, most recently from 6216558 to 7d6e5e1 Compare October 17, 2024 14:37
@SRodi SRodi added this pull request to the merge queue Oct 18, 2024
Merged via the queue into microsoft:main with commit db5f810 Oct 18, 2024
22 checks passed
@SRodi SRodi deleted the fix/docs branch October 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants