-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(basic-metrics): Remove label from basic dns and filter out IPs from linux util plugins #877
Merged
jimassa
merged 9 commits into
microsoft:main
from
jimassa:jmassa/metrics_cardinality_fix
Oct 26, 2024
Merged
fix(basic-metrics): Remove label from basic dns and filter out IPs from linux util plugins #877
jimassa
merged 9 commits into
microsoft:main
from
jimassa:jmassa/metrics_cardinality_fix
Oct 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhabMajumdar
previously approved these changes
Oct 25, 2024
anubhabMajumdar
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the cardinality issue in two basic plugins. By removing the label from basic dns and excluding localhost and node ip from linux util plugin tcp_connection_remote.
It also adds a check in the e2e to validate metrics without checking specific labels.
Related Issue
https://github.com/azure-networking/retina-enterprise/issues/263
https://github.com/azure-networking/retina-enterprise/issues/272
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Before, nodeIP is 10.224.2.241
after. No nodeIP or localhost
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.