Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ct): correctly pass reverse key for deletion from conntrack map #892

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

SRodi
Copy link
Member

@SRodi SRodi commented Oct 25, 2024

Description

We wrongly pass key reference to _ct_should_report_packet when the connection is found based on the reverse_key, this key is then removed as part of GC when the connection timed out or if it is a TCP connection and FIN or RST flags are set.

This PR fixes the issue by passing the correct key reference which is reverse_key

Related Issue

#807

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@SRodi SRodi added type/fix Fixes something area/ebpf labels Oct 25, 2024
@SRodi SRodi requested a review from a team as a code owner October 25, 2024 13:54
@nddq nddq added this pull request to the merge queue Oct 25, 2024
Merged via the queue into microsoft:main with commit f600eca Oct 25, 2024
22 checks passed
@SRodi SRodi deleted the fix/ct_key_del branch October 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ebpf type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants