fix: Revert "deps: bump google.golang.org/grpc from 1.66.2 to 1.67.0 (#765)" #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0dc47e0.
timraymond
changed the title
anubhabMajumdar
approved these changes
Nov 4, 2024
Upgrading gRPC automatically has caused regressions, therefore this should be done manually. If the offending breakage is resolved, we can remove this and use extra vigilance enforced by CI to detect breakage.
timraymond
force-pushed
the
traymond/revert-grpc-update
branch
from
f9b7688 to
b3cf06c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0dc47e0.
It was found, via bisecting, that this upgrade of gRPC caused #921. When investigating that issue, it was found (using
openssl) that agent pods did successfully establish TLS connections using the certificates generated by certgen. However, some issue existed with gRPC itself. The protobufs for the peer service have not changed since ~2022, so this upgrade is a sensible implication for the bug.Closes #921