Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default ConnectTimeout to a finite value #1991

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Set the default ConnectTimeout to a finite value #1991

merged 1 commit into from
Jan 11, 2023

Conversation

MihaZupan
Copy link
Member

Closes #1678

@MihaZupan MihaZupan added this to the YARP 2.0.0 milestone Jan 6, 2023
@MihaZupan MihaZupan self-assigned this Jan 8, 2023
Tratcher
Tratcher approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to https://github.com/microsoft/reverse-proxy/blob/main/src/ReverseProxy/Configuration/HttpClientConfig.cs too?

@MihaZupan
Copy link
Member Author

I'm not sure it'd get much use. Do you think people would want to change it from the config to potentially lower it even further?

@Tratcher
Copy link
Member

I'm not sure it'd get much use. Do you think people would want to change it from the config to potentially lower it even further?

Setting it by default might be enough. We can revisit later if there's demand.

@MihaZupan MihaZupan merged commit bd289ed into microsoft:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees

@MihaZupan MihaZupan

Labels
Breaking-Change
Projects
None yet
Milestone
YARP 2.0.0-RC1
Development

Successfully merging this pull request may close these issues.

Consider setting a finite ConnectTimeout by default
2 participants
@MihaZupan @Tratcher