Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ITransformBuilder available for IHttpProxy #951

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Apr 27, 2021

Fixes #949
ITransformBuilder recently added the Create API for use with IHttpProxy, but ITransformBuilder isn't actually registered in DI by AddHttpProxy. This moves the registration down a layer.

cc: @leastprivilege

@Tratcher Tratcher self-assigned this Apr 27, 2021
@Tratcher Tratcher added this to the YARP 1.0.0-preview12 milestone Apr 27, 2021
@Tratcher Tratcher requested a review from Kahbazi April 27, 2021 00:14
@Tratcher Tratcher added the Type: Bug Something isn't working label Apr 27, 2021
@Tratcher Tratcher merged commit bcd966d into main Apr 27, 2021
@Tratcher Tratcher deleted the tratcher/transformservice branch April 27, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transforms and direct proxying (re-visited)
3 participants