Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metro-serializer-esbuild): default to the new hermes target #1706

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 30, 2022

Description

Default to the new hermes target introduced in esbuild 0.14.48.

Resolves #1670.

Test plan

Existing tests should pass.

@tido64 tido64 added the feature: metro This is related to Metro label Jun 30, 2022
@tido64 tido64 merged commit 38a1065 into microsoft:main Jun 30, 2022
@tido64 tido64 deleted the tido/use-hermes-profile branch June 30, 2022 15:00
@ecreeth
Copy link

ecreeth commented Jun 30, 2022

@tido64 I just found that in the esbuild compact table of features, the ConstAndLet one is added in the hermes target. I don't know how they handle that, but i think is wrong.

@tido64
Copy link
Member Author

tido64 commented Jun 30, 2022

@tido64 I just found that in the esbuild compact table of features, the ConstAndLet one is added in the hermes target. I don't know how they handle that, but i think is wrong.

@ecreeth: No, I think this is "correct". Hermes does support const, kind of. It supports the keyword, but none of its features 😛 Not sure if it affects how esbuild transpiles stuff. Do you know? Did you file an issue?

@ecreeth
Copy link

ecreeth commented Jun 30, 2022

@ecreeth: No, I think this is "correct". Hermes does support const, kind of. It supports the keyword, but none of its features 😛 Not sure if it affects how esbuild transpiles stuff. Do you know? Did you file an issue?

🤷‍♂️ I don't know how they do it, nor did I fill out a issue.

@tido64
Copy link
Member Author

tido64 commented Jul 1, 2022

Filed evanw/esbuild#2365. Let's see what Evan says.

@ecreeth: Thanks again for being on top of these things. I really appreciate it. 🙏

tido64 added a commit to tido64/rnx-kit that referenced this pull request Jul 6, 2022
- Updates config schema to reflect breaking changes
- Reverts microsoft#1706 - "Default to the new `hermes` target"
tido64 added a commit that referenced this pull request Jul 6, 2022
- Updates config schema to reflect breaking changes
- Reverts #1706 - "Default to the new `hermes` target"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: metro This is related to Metro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metro-serializer-esbuild: target ES6 with individual features disabled
3 participants