Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(align-deps): copy from dep-check #1927

Merged
merged 1 commit into from
Oct 10, 2022
Merged

feat(align-deps): copy from dep-check #1927

merged 1 commit into from
Oct 10, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 10, 2022

Description

This is a plain copy of dep-check.

Test plan

CI should pass.

This was referenced Oct 10, 2022
Closed
Merged
kelset
kelset approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a followup PR can you add in the readme something like "this package used to be called dep-check, you can read more about why the change happened here" and link to the RFC?

@tido64
Copy link
Member Author

tido64 commented Oct 10, 2022

as a followup PR can you add in the readme something like "this package used to be called dep-check, you can read more about why the change happened here" and link to the RFC?

Yeah, we will have to rewrite the README. I'll make sure to include the RFC as well.

@tido64 tido64 merged commit c4ee2f8 into microsoft:main Oct 10, 2022
@tido64 tido64 deleted the tido/align-deps branch October 10, 2022 12:30
@tido64 tido64 added the feature: align-deps This is related to align-deps label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@afoxman afoxman Awaiting requested review from afoxman

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: align-deps This is related to align-deps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @kelset