Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(align-deps): migrate init command #1938

Merged
merged 6 commits into from
Oct 20, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 18, 2022

Description

Migrates "init" command to the new config schema.

Test plan

Build align-deps:

cd packages/align-deps
yarn build --dependencies
cd ../test-app

Initialize a new config:

node ../align-deps/lib/cli.js --init

Inspect the generated config and verify that it corresponds to the old config.

Tests were migrated as well.

@tido64 tido64 added the feature: align-deps This is related to align-deps label Oct 18, 2022
@tido64 tido64 mentioned this pull request Oct 18, 2022
24 tasks
@tido64
Copy link
Member Author

tido64 commented Oct 18, 2022

@afoxman, @kelset: For reference, this is as close to the final state as it currently gets: https://github.com/tido64/rnx-kit/tree/tido/align-deps/better-unresolved-message/packages/align-deps

I realise that some things may look weird and questionable while things are still in a "mixed" state. Even after merging the last changes, I will do another round to make sure everything is throughly cleaned up. Hopefully, everything will make sense by the end of it all.

packages/align-deps/src/capabilities.ts Outdated Show resolved Hide resolved
packages/align-deps/src/capabilities.ts Outdated Show resolved Hide resolved
packages/align-deps/src/capabilities.ts Outdated Show resolved Hide resolved
packages/align-deps/src/cli.ts Show resolved Hide resolved
packages/align-deps/src/commands/check.ts Show resolved Hide resolved
packages/align-deps/src/commands/initialize.ts Outdated Show resolved Hide resolved
@tido64 tido64 merged commit 1a13c1f into microsoft:main Oct 20, 2022
@tido64 tido64 deleted the tido/align-deps/init branch October 20, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: align-deps This is related to align-deps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants